[SQL] Hotfix: az sql dw update: fix update to not accept backup-storage-redundancy #16236
Conversation
xaliciayang
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
|
"FAIL - MEDIUM severity: parameter_should_not_end_in_resource_group" Is this a new rule? The parameters in question have existed for a long time. Also they should have target RG parameters. |
|
SQL |
|
@evelyn-ys Can you help take a look at the failures? |
medium errors is not a blocker for the CI and the root cause is that there is a high severity. The high one could be fixed when the PR is merged #16297. |
|
Hi @xaliciayang, would server side return error when the parameter is used before? |
Hi @Juliehzl yes; SQL DW currently does not support updating this value so sql dw update returned an error when customer tried. |
xaliciayang
changed the title
xaliciayang
requested review from
aim-for-better,
bgklein,
bim-msft,
dbradish-microsoft,
digimaun,
fengzhou-msft,
haroldrandom,
idear1203,
jiasli,
jsntcy,
kairu-ms,
msyyc,
qwordy,
sunsw1994 and
yungezz
as code owners
xaliciayang
force-pushed
the
sqlDwBsrFix
branch
from
aaf6dfb to
d23fc30
Compare
|
@evelyn-ys could this PR get merged? |
xaliciayang
force-pushed
the
sqlDwBsrFix
branch
from
c75cd29 to
d23fc30
Compare
I am discussing with @xaliciayang about whether to ship a hotfix or not. If a hotfix is necessary, changes should be merged into 'release' branch. She may have to do some duplicate work to pass CI as #16306 #16297 have already done to fix CI for 'dev' branch. |
|
sql has some test failures. |
|
moved to #16326 |
5 participants
Description
A previous PR from earlier this year added backup-storage-redundancy to all SQL create/update methods. This inadvertently added the functionality to SQL DW as well. However, this parameter should not be available during dw update (not supported in the backend), so this PR removes the customer's ability to update a DW's backup storage redundancy.
Additionally, this fixes an issue for az sql db update; where the update command was not updating backup storage redundancy values on existing databases.
Testing Guide
History Notes
[SQL] az sql dw update: do not accept backup-storage-redundancy argument
[SQL] az sql db update: update backup storage redundancy as requested from command
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.